Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getblock.transactions #7151

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Fix getblock.transactions #7151

merged 4 commits into from
Jul 16, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Jul 15, 2024

Description

#7090
when using eth.getBlock() and we recieve a block with no transactions block.transactions property should be an empty array but returns undefined. This is due to the format function not defaulting to an empty array not matching any trasaction schemas. Will need to fix format function. relates to this
Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Jul 15, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 636 kB → 636.12 kB (+128 B) +0.02%
Changeset
File Δ Size
../web3-eth/lib/commonjs/rpc_method_wrappers.js 📈 +272 B (+0.64%) 41.38 kB → 41.64 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 616.7 kB → 616.83 kB (+128 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 79d250a Previous: 6b80cf0 Ratio
processingTx 9460 ops/sec (±3.57%) 9439 ops/sec (±3.74%) 1.00
processingContractDeploy 40472 ops/sec (±6.09%) 40790 ops/sec (±6.86%) 1.01
processingContractMethodSend 15986 ops/sec (±9.94%) 16075 ops/sec (±6.85%) 1.01
processingContractMethodCall 28212 ops/sec (±6.08%) 26970 ops/sec (±8.10%) 0.96
abiEncode 43452 ops/sec (±8.87%) 43844 ops/sec (±7.10%) 1.01
abiDecode 31261 ops/sec (±7.12%) 30447 ops/sec (±7.63%) 0.97
sign 1537 ops/sec (±4.34%) 1584 ops/sec (±0.51%) 1.03
verify 372 ops/sec (±0.50%) 358 ops/sec (±2.93%) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (6b80cf0) to head (79d250a).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7151   +/-   ##
=======================================
  Coverage   94.45%   94.46%           
=======================================
  Files         215      215           
  Lines        8391     8396    +5     
  Branches     2313     2315    +2     
=======================================
+ Hits         7926     7931    +5     
  Misses        465      465           
Flag Coverage Δ
UnitTests 94.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex luu-alex marked this pull request as ready for review July 15, 2024 17:31
@luu-alex luu-alex changed the title Fix getblock Fix getblock.transactions Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants