-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getblock.transactions #7151
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 79d250a | Previous: 6b80cf0 | Ratio |
---|---|---|---|
processingTx |
9460 ops/sec (±3.57% ) |
9439 ops/sec (±3.74% ) |
1.00 |
processingContractDeploy |
40472 ops/sec (±6.09% ) |
40790 ops/sec (±6.86% ) |
1.01 |
processingContractMethodSend |
15986 ops/sec (±9.94% ) |
16075 ops/sec (±6.85% ) |
1.01 |
processingContractMethodCall |
28212 ops/sec (±6.08% ) |
26970 ops/sec (±8.10% ) |
0.96 |
abiEncode |
43452 ops/sec (±8.87% ) |
43844 ops/sec (±7.10% ) |
1.01 |
abiDecode |
31261 ops/sec (±7.12% ) |
30447 ops/sec (±7.63% ) |
0.97 |
sign |
1537 ops/sec (±4.34% ) |
1584 ops/sec (±0.51% ) |
1.03 |
verify |
372 ops/sec (±0.50% ) |
358 ops/sec (±2.93% ) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7151 +/- ##
=======================================
Coverage 94.45% 94.46%
=======================================
Files 215 215
Lines 8391 8396 +5
Branches 2313 2315 +2
=======================================
+ Hits 7926 7931 +5
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
#7090
when using eth.getBlock() and we recieve a block with no transactions block.transactions property should be an empty array but returns undefined. This is due to the format function not defaulting to an empty array not matching any trasaction schemas. Will need to fix format function. relates to this
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.