Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4x tests updates #7162

Merged
merged 21 commits into from
Aug 2, 2024
Merged

4x tests updates #7162

merged 21 commits into from
Aug 2, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jul 18, 2024

Description

#5079

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Jul 18, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 636.12 kB → 636.25 kB (+132 B) +0.02%
Changeset
File Δ Size
../web3-core/lib/commonjs/web3_config.js 📈 +314 B (+1.88%) 16.34 kB → 16.65 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 616.83 kB → 616.96 kB (+132 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 1edaf85 Previous: 61e9e06 Ratio
processingTx 8871 ops/sec (±3.71%) 8729 ops/sec (±4.67%) 0.98
processingContractDeploy 40419 ops/sec (±6.25%) 37973 ops/sec (±6.91%) 0.94
processingContractMethodSend 16336 ops/sec (±8.26%) 15996 ops/sec (±6.56%) 0.98
processingContractMethodCall 28172 ops/sec (±6.07%) 27488 ops/sec (±6.50%) 0.98
abiEncode 43095 ops/sec (±6.91%) 43224 ops/sec (±7.07%) 1.00
abiDecode 29485 ops/sec (±8.81%) 29694 ops/sec (±7.87%) 1.01
sign 1531 ops/sec (±3.23%) 1501 ops/sec (±3.13%) 0.98
verify 377 ops/sec (±0.58%) 368 ops/sec (±0.51%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (6b80cf0) to head (1edaf85).
Report is 10 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7162   +/-   ##
=======================================
  Coverage   94.45%   94.46%           
=======================================
  Files         215      215           
  Lines        8391     8400    +9     
  Branches     2313     2318    +5     
=======================================
+ Hits         7926     7935    +9     
  Misses        465      465           
Flag Coverage Δ
UnitTests 94.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -203,7 +203,7 @@ describe('defaults', () => {
expect(web3Eth.defaultBlock).toBe('earliest');

// set by create new instance
eth2 = new Web3Eth({
const eth2 = new Web3Eth({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using local instances so different tests dnt interfere each other's values , and locally close connection instead of closing on last instance at end and other instances dangling

key === 'maxListenersWarningThreshold' )
{
// additionally set in event emitter
this.setMaxListenerWarningThreshold(Number(options[key]));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug fix: #5079 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants