fix(Select): html respects value passed (#1053)

web3ui · Mar 28, 2023 · 8d3ce22 · 8d3ce22
1 parent eae77c6
commit 8d3ce22
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/.changeset/slow-jobs-peel.md b/.changeset/slow-jobs-peel.md
@@ -0,0 +1,5 @@
+---
+'@web3uikit/core': patch
+---
+
+fix(Select): html respects value passed
diff --git a/packages/core/src/lib/Select/TraditionalSelect/TraditionalSelect.tsx b/packages/core/src/lib/Select/TraditionalSelect/TraditionalSelect.tsx
@@ -30,20 +30,21 @@ const TraditionalSelect: React.FC<ISelectProps> = ({
     width = '200px',
     ...props
 }: ISelectProps) => {
-    const [currentValue, setCurrentValue] = useState<
-        string | number | string[]
-    >();
+    const [currentValue, setCurrentValue] = useState('');
 
     useEffect(() => {
         if (!value) return;
-        setCurrentValue(value);
+        const dayObject = options.find((item) => item.label === value);
+        typeof dayObject?.label === 'string' &&
+            setCurrentValue(dayObject?.label);
     }, [value]);
 
     useEffect(() => {
         if (Number(defaultOptionIndex) < 0) return;
         if (Number(defaultOptionIndex) > options.length) return;
 
-        setCurrentValue(options[Number(defaultOptionIndex)]?.label || '');
+        const value = options[Number(defaultOptionIndex)]?.label;
+        typeof value === 'string' && setCurrentValue(value);
     }, [defaultOptionIndex]);
 
     const handleChange = (event: React.ChangeEvent<HTMLSelectElement>) => {