Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): HTML 5 default index & placeholder #1009

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

BillyG83
Copy link
Contributor

Default with no placeholder set

Render
Screenshot 2023-01-23 at 11 57 25

Open
Screenshot 2023-01-23 at 11 57 30

With placeholder

Redner
Screenshot 2023-01-23 at 11 57 37

Open
Screenshot 2023-01-23 at 11 57 42

With default index

Render
Screenshot 2023-01-23 at 11 57 49

Open
Screenshot 2023-01-23 at 11 57 57

@BillyG83 BillyG83 linked an issue Jan 23, 2023 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

🦋 Changeset detected

Latest commit: 35a25a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@AbhinavMV AbhinavMV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

size-limit report 📦

Path Size
packages/core/dist/index.js 341.7 KB (+0.01% 🔺)
packages/icons/dist/index.es.js 135.66 KB (0%)
packages/web3/dist/index.js 1.51 MB (0%)
packages/web3uikit/dist/index.js 1.96 MB (+0.01% 🔺)

@BillyG83 BillyG83 merged commit ee7704f into master Jan 23, 2023
@BillyG83 BillyG83 deleted the 1008-select-html5-default-index branch January 23, 2023 11:32
@github-actions github-actions bot mentioned this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select]: Traditional HTML5 mode default index
2 participants