Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): hasCancel boolean added, onCancelButtonPress event added #101

Merged
merged 2 commits into from
Jan 25, 2022
Merged

fix(Modal): hasCancel boolean added, onCancelButtonPress event added #101

merged 2 commits into from
Jan 25, 2022

Conversation

BillyG83
Copy link
Contributor

  • hasCancel optional boolean added, default true, so cancel button can be hidden, CSS fix so ok is always aligned right even without a sibling
  • remove all state React code, it should not govern its own state
  • added onCancelButtonPress event so the next dev can flip isVisable or better yet unrender the Modal (docs added)
  • minor alignment

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/web3uikit.cjs.production.min.js 609.64 KB (-0.01% 🔽)
dist/web3uikit.esm.js 592.83 KB (-0.01% 🔽)

@locothedev
Copy link
Collaborator

Thank you bro

@locothedev locothedev merged commit 981fffe into master Jan 25, 2022
@locothedev locothedev deleted the fix-Modal-closing-optional-cancel branch January 25, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyG83 @locothedev