Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Toggle): added component #1054

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

BillyG83
Copy link
Contributor

@BillyG83 BillyG83 commented Mar 28, 2023

added component

it has noral HTML events plus onToggle to get the value back as string for on and off

off / left
Screenshot 2023-03-28 at 22 47 13

on / right
Screenshot 2023-03-28 at 22 47 18

customize
Screenshot 2023-03-28 at 22 47 27
Screenshot 2023-03-28 at 22 47 36

@BillyG83 BillyG83 added the feature New feature or request label Mar 28, 2023
@BillyG83 BillyG83 self-assigned this Mar 28, 2023
@BillyG83 BillyG83 linked an issue Mar 28, 2023 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

🦋 Changeset detected

Latest commit: 44acf65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/core/dist/index.js 342.44 KB (+0.05% 🔺)
packages/icons/dist/index.es.js 147.2 KB (0%)
packages/web3/dist/index.js 1.51 MB (+0.09% 🔺)
packages/web3uikit/dist/index.js 1.98 MB (+0.34% 🔺)

Copy link
Collaborator

@AbhinavMV AbhinavMV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Noticed 1 thing that design for this are a bit different. the toggle button is a bit different in design. I guess its not a blocker right now ?

image

@BillyG83
Copy link
Contributor Author

LGTM 🚀

Noticed 1 thing that design for this are a bit different. the toggle button is a bit different in design. I guess its not a blocker right now ?

image

yeah thats good feedback i will update the styles TY

@BillyG83 BillyG83 merged commit cf79f76 into master Mar 31, 2023
@BillyG83 BillyG83 deleted the 998-switch-optional-label-on-the-left branch March 31, 2023 07:03
@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Switch] optional label on the left
2 participants