Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icons #858

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Add new icons #858

merged 3 commits into from
Oct 25, 2022

Conversation

Maki44
Copy link
Contributor

@Maki44 Maki44 commented Oct 25, 2022


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

Related issue: #FILL_THIS_OUT

Solution Description

Added Icons

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

🦋 Changeset detected

Latest commit: 24c69d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Maki44 Maki44 requested a review from AbhinavMV October 25, 2022 14:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

size-limit report 📦

Path Size
packages/core/dist/index.js 265.92 KB (0%)
packages/icons/dist/index.es.js 64.37 KB (+1.75% 🔺)
packages/web3/dist/index.js 1.44 MB (+0.08% 🔺)
packages/web3uikit/dist/index.js 1.76 MB (+0.14% 🔺)

Copy link
Contributor

@BillyG83 BillyG83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep an eye on what files you commit... nothing "wrong" with this but 133 changes for 6 new SVGs is kind of overkill... thanks linting XD

oh you are missing the version bump file @Maki44

@BillyG83
Copy link
Contributor

i added the changeset file for you @Maki44 134 changes now XD

Copy link
Contributor

@BillyG83 BillyG83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job @Maki44

@BillyG83 BillyG83 merged commit 1bf136d into master Oct 25, 2022
@BillyG83 BillyG83 deleted the feat/add-new-icons branch October 25, 2022 15:27
@github-actions github-actions bot mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants