Add some props to PlanCard #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 245feee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Maki44
requested review from
AbhinavMV and
BillyG83
and removed request for
AbhinavMV
size-limit report 📦
|
AbhinavMV
reviewed
Nov 10, 2022
| /** | ||
| * Card background color | ||
| */ | ||
| backgroundColor?: typeof color | string; |
There was a problem hiding this comment.
for typeof color to work inside the component you have to use color[backgroundColor] since that is not being done this can be removed since we are are also taking string
|
@Maki44 Just have that one comment, rest everything looks good |
added 3 commits
November 10, 2022 10:51
…ui/web3uikit into fix/planCard-to-support-admin-style
AbhinavMV
approved these changes
Nov 10, 2022
|
Nice work LGTM 🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 'Pull request'
about: A new pull request
New Pull Request
Checklist
Issue Description
related to issue
Solution Description
New Looks