Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BannerStrip): position relative should not use z-index, top or left #900

Merged
merged 2 commits into from
Nov 16, 2022
Merged

fix(BannerStrip): position relative should not use z-index, top or left #900

merged 2 commits into from
Nov 16, 2022

Conversation

BillyG83
Copy link
Contributor

Screenshot 2022-11-16 at 15 27 43

  1. position fixed should not add z-index, top or left... they are not needed
  2. sorted CSS and props 🔤
  3. added style prop for margin in admin

@BillyG83 BillyG83 added the bug Something isn't working label Nov 16, 2022
@BillyG83 BillyG83 self-assigned this Nov 16, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: f3d5833

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022 •
edited
Loading

size-limit report 📦

Path Size
packages/core/dist/index.js 285.74 KB (+0.01% 🔺)
packages/icons/dist/index.es.js 79.76 KB (0%)
packages/web3/dist/index.js 1.45 MB (+0.01% 🔺)
packages/web3uikit/dist/index.js 1.8 MB (+0.01% 🔺)

AbhinavMV
AbhinavMV approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@AbhinavMV AbhinavMV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice fix 🚀

Just added changeset file for release 🙌🏻

@AbhinavMV AbhinavMV merged commit 7c4cf57 into master Nov 16, 2022
@AbhinavMV AbhinavMV deleted the fix-banner-strip-zindex branch November 16, 2022 16:24
@github-actions github-actions bot mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhinavMV AbhinavMV AbhinavMV approved these changes

Assignees

@BillyG83 BillyG83

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyG83 @AbhinavMV