Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callbacks #914

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Add callbacks #914

merged 2 commits into from
Nov 23, 2022

Conversation

Maki44
Copy link
Contributor

@Maki44 Maki44 commented Nov 22, 2022


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

Related issue: #Admin Issue

Solution Description

Add Callbacks

  • onCopy
  • onReveal

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2022

🦋 Changeset detected

Latest commit: f8de813

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

size-limit report 📦

Path Size
packages/core/dist/index.js 286.05 KB (+0.01% 🔺)
packages/icons/dist/index.es.js 126.44 KB (0%)
packages/web3/dist/index.js 1.45 MB (0%)
packages/web3uikit/dist/index.js 1.85 MB (+0.01% 🔺)

@AbhinavMV AbhinavMV merged commit 2beebd5 into master Nov 23, 2022
@AbhinavMV AbhinavMV deleted the fix/add-callback-credentials branch November 23, 2022 05:20
@AbhinavMV
Copy link
Collaborator

Looks nice 🚀
My bad i thought this was already present in credentials but it was in copy button 🙇🏻

@github-actions github-actions bot mentioned this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants