[Accordion]: customize open and close icon #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bb4e37d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AbhinavMV
changed the title
size-limit report 📦
|
Maki44
approved these changes
Nov 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 'Pull request'
about: A new pull request
New Pull Request
Checklist
Issue Description
Related issue: #
FILL_THIS_OUTSolution Description
Reasons to use
react-animate-heightinstead ofmax-heightsolutionMax height was set to content height when it was opened the first time, if the content expanded after being opened then it was not taken into consideration.
Now let's say we take that into consideration -> by setting max-height='max-content' in the
onTransitionEndcallback.The solution works but the transition on closing the accordion stops working.
After research found that max-height is just a hacky way to solve this problem. So instead it would be better to use this package that does the work for us and also helps us to remove many state variables 😄