Fix updates needed for new project #942
Conversation
🦋 Changeset detectedLatest commit: 687f474 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| ${(p) => | ||
| p.customize?.onHover && p.customize?.onHover === 'lighten' | ||
| ? 'filter: brightness(1.1)' | ||
| : 'filter: brightness(10%)'}; |
There was a problem hiding this comment.
Maybe something is wrong here
But on hovering over any input story it goes black 🙈
| @@ -11,6 +11,7 @@ const Tag: React.FC<TagProps> = ({ | |||
| hasCancel = false, | |||
| id, | |||
| onCancelClick, | |||
| padding, | |||
| text = 'Tag', | |||
| theme = 'regular', | |||
| tone = 'light', | |||
There was a problem hiding this comment.
padding needs to be passed to TagStyled tag 🙈
There was a problem hiding this comment.
Also in this file below on line 48, old color is being used. Looks like we missed this file.
<Cross title="cross icon" titleId="tag cross icon" fill={colors.grey} />
There was a problem hiding this comment.
I THOUGHT YOU WERE SUPPOSED TO BE TAKING THE WEEKEND OFF!!!
LOL! great catches TY, it was late 😅
There was a problem hiding this comment.
fixed TY @AbhinavMV 🙇
Tag custom padding added