Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable center align for dpdw content + fix alignment #954

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

dani69654
Copy link
Collaborator

@dani69654 dani69654 commented Dec 14, 2022

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2022

🦋 Changeset detected

Latest commit: 488a2d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

size-limit report 📦

Path Size
packages/core/dist/index.js 331.25 KB (+0.05% 🔺)
packages/icons/dist/index.es.js 131.36 KB (0%)
packages/web3/dist/index.js 1.5 MB (+0.01% 🔺)
packages/web3uikit/dist/index.js 1.94 MB (+0.02% 🔺)

Copy link
Collaborator

@AbhinavMV AbhinavMV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey bro nice work
Just have some questions

  1. When the option with icon (eg: testnet) is selected, this is how it is displayed. Is this how it should be displayed? 🤔
    image

  2. From the design in the issue I can see that even the dropdown arrow is centered. but not in the story. Maybe design was not updated not sure.

If these two things are ok and no changes are needed to PR please go ahead and merge this @dani69654 🙌🏻

@dani69654
Copy link
Collaborator Author

dani69654 commented Dec 15, 2022

Hey @AbhinavMV , thanks for reviewing:

When the option with icon (eg: testnet) is selected, this is how it is displayed. Is this how it should be displayed?

This is how it works now, not sure if it is correct, I did not work on that in this MR. If we don't like it we can surely change its behaviour.

From the design in the issue I can see that even the dropdown arrow is centered. but not in the story. Maybe design was not updated not sure.

You are right, I missed that. On it, good catch

@dani69654 dani69654 force-pushed the feat/dropdown-justify-prop-and-align-center branch from c2081cf to 3da7a69 Compare December 15, 2022 09:00
@dani69654
Copy link
Collaborator Author

Screenshot 2022-12-15 at 10 01 39

Copy link
Collaborator

@AbhinavMV AbhinavMV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AbhinavMV AbhinavMV merged commit bacd195 into master Dec 15, 2022
@AbhinavMV AbhinavMV deleted the feat/dropdown-justify-prop-and-align-center branch December 15, 2022 09:27
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dropdown] align center and add justify content prop
2 participants