-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable center align for dpdw content + fix alignment #954
enable center align for dpdw content + fix alignment #954
Conversation
🦋 Changeset detectedLatest commit: 488a2d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey bro nice work
Just have some questions
-
When the option with icon (eg: testnet) is selected, this is how it is displayed. Is this how it should be displayed? 🤔
-
From the design in the issue I can see that even the dropdown arrow is centered. but not in the story. Maybe design was not updated not sure.
If these two things are ok and no changes are needed to PR please go ahead and merge this @dani69654 🙌🏻
Hey @AbhinavMV , thanks for reviewing:
This is how it works now, not sure if it is correct, I did not work on that in this MR. If we don't like it we can surely change its behaviour.
You are right, I missed that. On it, good catch |
c2081cf
to
3da7a69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
closes #951
https://www.loom.com/share/8cbcb798db7f4156b998db424383f99e