Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Card]: add checkmark icon position #955

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Conversation

AbhinavMV
Copy link
Collaborator


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

Related issue: #FILL_THIS_OUT

Solution Description

checkMarkPosition: left | right

image

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2022

🦋 Changeset detected

Latest commit: f3bfaf6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/core/dist/index.js 292.19 KB (+0.01% 🔺)
packages/icons/dist/index.es.js 131.36 KB (0%)
packages/web3/dist/index.js 1.46 MB (0%)
packages/web3uikit/dist/index.js 1.86 MB (+0.01% 🔺)

@dani69654
Copy link
Collaborator

@AbhinavMV Good job, works well.

@AbhinavMV AbhinavMV merged commit 88ae36e into master Dec 15, 2022
@AbhinavMV AbhinavMV deleted the add-position-prop-for-card branch December 15, 2022 09:42
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants