-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal,NftCard,Select,Input,]: Bug fix and feature added #983
Changes from all commits
393a761
43ccad5
ea3d6d6
1fe5710
d6af3d8
11bbf17
5cad9e3
e294a86
b99249d
b71dae4
4958554
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@web3uikit/core': patch | ||
'@web3uikit/styles': patch | ||
--- | ||
|
||
Modal,NftCard,Select,InputNew - fix multiple bugs and add features, and add new color |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -167,7 +167,7 @@ const DivStyledOverlay = styled.div` | |
bottom: 0; | ||
display: none; | ||
left: 0; | ||
position: absolute; | ||
position: fixed; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this correct? wont the overlay be fixed to the page instead of the parent? does this casue an issue when you scroll the page? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the overlay is used to close the select menu if someone clicks outside of the select. If absolute is used it takes the parent size which is usually not the screen size so the menu won't be closed. (checkout select component in admin playground it won't close even if clicked outside) But if fixed is used it take up entire screen and if user clicks anywhere the select component will be closed |
||
right: 0; | ||
top: 0; | ||
z-index: 2; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why minus -1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on password type input, when you click tab it focuses on the password icon to avoid this negative index is being used. (Never seen any site implement focusing on the password icon)
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex