Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Credentials,Tooltip]: Added customize prop and tooltips for icon #991

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

AbhinavMV
Copy link
Collaborator


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

Related issue: #FILL_THIS_OUT

Solution Description

Tooltip - Added arrow size change prop and customize prop

image

Credentials - Added prop for showing tooltips on icons

image

Both changes are linked to each other so doing it in the same PR

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2023

🦋 Changeset detected

Latest commit: 12609b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

size-limit report 📦

Path Size
packages/core/dist/index.js 340.16 KB (+0.16% 🔺)
packages/icons/dist/index.es.js 132.01 KB (0%)
packages/web3/dist/index.js 1.5 MB (+0.03% 🔺)
packages/web3uikit/dist/index.js 1.95 MB (+0.05% 🔺)

Copy link
Contributor

@BillyG83 BillyG83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure about have 2 version of copy and hide... but we can merge this now if you need it and iterate later

@AbhinavMV
Copy link
Collaborator Author

Yeah agreed did not think clearly on that, will create follow up issue to fix that 🙌🏻

@AbhinavMV AbhinavMV merged commit d506933 into master Jan 4, 2023
@AbhinavMV AbhinavMV deleted the feat/credentials-tooltip branch January 4, 2023 09:49
@github-actions github-actions bot mentioned this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants