Example site layout updates. #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataChannel support
Connect WebSocket relative to window.location
variable should be declared
…hashes There is an issue on page load when you have a room hash in the url. You get a url fragment error and the socket connection does not succeed
URL fragment issue
…l for Heroku, CloudBees, cloud9), fallback to 8080
Listing port defined in env variable
Updated webrtc.io.js
…een firefox and chrome to but I have not gotten the media to play back. I dont know why the video is not playing back in the video tag... any one please have a look
…t echo during local testing. Videos need a hover control for the audio.
…d a new popup screen for joining existing rooms. Added some code to clean up the room list when someone disconnects from a room. Changed the use of hashtags for joining rooms to query strings to force the browser to make a new connection. subdivideVideos function to properly calculate video sizes given a predetermined aspect ratio (4/3).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick commit: ajbogh@cab9299
Git shows 82 commits for some reason, not sure why. Feel free to cherry-pick for safety.
In the above commit I changed the example site layout. The remote videos are laid out on the left in a similar row/column format as before. The subdivide function has been fixed and the remote videos have been muted to prevent echoing in local testing. The audio can be unmuted by right-clicking the video.
The buttons are now on the right with the local video below them. The chat section is below the local video, taking up the remainder of the space. The toggle chat button is removed but it can be added back in at a later date.
Removing a remote video will now cause a subdivide task to execute once more.
The background has been changed to black to bring out more of the video.