Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tangle-dapp): Added Logic To Handle Ledger Signature #2301

Closed
wants to merge 1 commit into from

Conversation

AtelyPham
Copy link
Member

Summary of changes

Provide a detailed description of proposed changes.

  • Added logic to handle signature from Ledger on both EVM & Substrate

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/tangle-dapp
  • apps/testnet-leaderboard
  • apps/faucet
  • apps/zk-explorer
  • libs/webb-ui-components

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

@AtelyPham AtelyPham added the needs review 👓 Pull request needs a review label May 8, 2024
@AtelyPham AtelyPham self-assigned this May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit e608e6c
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/663b54028f98d20008ea237a
😎 Deploy Preview https://deploy-preview-2301--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AtelyPham AtelyPham requested review from drewstone and 1xstj May 8, 2024 11:13
@drewstone
Copy link
Contributor

How has this been tested?

@AtelyPham
Copy link
Member Author

How has this been tested?

I haven't tested it yet, just ask @1xstj to help me test it locally.

@drewstone drewstone closed this May 9, 2024
@AtelyPham AtelyPham deleted the trung-tin/ensure-ledger-signature branch May 28, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 👓 Pull request needs a review
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

[BUG] Error message when attempting to claim airdrop at app.tangle.tools/claim
3 participants