Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2437 - Upgrades python ua-parser version to 0.8 #2444

Merged
merged 2 commits into from
May 10, 2018
Merged

Fix #2437 - Upgrades python ua-parser version to 0.8 #2444

merged 2 commits into from
May 10, 2018
+50 −16

Commits on May 9, 2018

  1. Issue webcompat#2437 - Upgrades python ua-parser version to 0.8

    @karlcow
    karlcow committed May 9, 2018
    Configuration menu
    Copy the full SHA
    fd8c65e View commit details
    Browse the repository at this point in the history

Commits on May 10, 2018

  1. Issue webcompat#2437 - Adds tests for rendering wrt addons 

    This does two things:
- Adds unittest tests to check that the right partial template for addons is sent depending on the user agent string.
- Adds a test for an unknown browser
- Fixes the template for addon where some white spaces where left over here and there.
- Removes the previous weaker functional tests which was very dependent on the testing browser.

It was triggered by the upgrade of ua-parser in python which took into account the headlesschrome user agent string, then not detected by our template. It was making the functional test fail.
See webcompat#2444 for the background.
    @karlcow
    karlcow committed May 10, 2018
    Configuration menu
    Copy the full SHA
    f0b60d3 View commit details
    Browse the repository at this point in the history