Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host and port to server start message #2457

Closed

Conversation

mischah
Copy link
Member

@mischah mischah commented May 18, 2018

I love to click those URLs in iTerm 😘

@Regaddi
Copy link
Member

Regaddi commented May 18, 2018

r? @karlcow @miketaylr

@mischah mischah requested a review from zoepage May 18, 2018 20:40
@mischah
Copy link
Member Author

mischah commented May 18, 2018

Sorry, just read https://github.com/webcompat/webcompat.com/blob/master/docs/pr-coding-guidelines.md

Let me know if you want me to create an issue to this PR.

@karlcow
Copy link
Member

karlcow commented May 20, 2018

@mischah Thanks for the PR. Yes always have an issue would be better. 👍
That said I think that would be a duplicate of #2445.

The message was displayed before and not only the message, but also the PIN Number for debugging flask. So we need to fix this. If you can figure out what went wrong (this is a regression), feel free to propose a PR. If you want me to prioritize it a bit, I can check this week.

@karlcow karlcow closed this May 20, 2018
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good proposal but which is not fixing the bulk of #2445

@miketaylr
Copy link
Member

(we could also merge this as a stop-gap until #2445 is fixed)

@mischah
Copy link
Member Author

mischah commented May 21, 2018

Thanks for the info @karlcow
I didn’t had a look at existing issues though. Because I just wanted to get started working on another issue but the missing info about the port in my terminal caught my attention.

@mischah
Copy link
Member Author

mischah commented May 21, 2018

Plus: No, sorry. I can’t help with a proper fix to #2445 because I have no clue about flask or Python in general 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants