Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use function overload to make the tagged template have the correct type #16

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

joakimbeng
Copy link
Contributor

Types of changes

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • docs change
  • breaking change

Motivation / Use-Case

Without this TypeScript complains when using the tagged template literal with the error:

error TS2554: Expected 1 arguments, but got 2

Breaking Changes

None

Additional Info


Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG.md.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ct type

Without this TypeScript complains when using the tagged template literal with the error: "error TS2554: Expected 1 arguments, but got 2"
@webdiscus webdiscus merged commit d325bbe into webdiscus:master Dec 14, 2023
3 checks passed
@webdiscus
Copy link
Owner

Hello @joakimbeng,

thank you for the fix! The fixed version is 2.0.3.

@joakimbeng joakimbeng deleted the patch-1 branch December 14, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants