Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump default binary to 0.29.0 #79

Merged
merged 2 commits into from
Jan 25, 2021
Merged

bump default binary to 0.29.0 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d25cff8
bump default binary to 0.29.0
dmlemeshko Jan 22, 2021
d4c8e84
1.22.0
dmlemeshko Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Use `GECKODRIVER_SKIP_DOWNLOAD` to skip the download of the geckodriver file.
## Versions

* [npm module version] - [geckodriver version]
* 1.22.x - geckodriver 0.29.0
* 1.21.x - geckodriver 0.28.0
* 1.20.x - geckodriver 0.27.0
* 1.19.x - geckodriver 0.26.0
Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if (skipDownload === 'true') {
var baseCDNURL = process.env.GECKODRIVER_CDNURL || process.env.npm_config_geckodriver_cdnurl || 'https://github.com/mozilla/geckodriver/releases/download';
var CACHED_ARCHIVE = process.env.GECKODRIVER_FILEPATH ? path.resolve(process.env.GECKODRIVER_FILEPATH) : undefined;

var version = process.env.GECKODRIVER_VERSION || process.env.npm_config_geckodriver_version || '0.28.0';
var version = process.env.GECKODRIVER_VERSION || process.env.npm_config_geckodriver_version || '0.29.0';

// Remove trailing slash if included
baseCDNURL = baseCDNURL.replace(/\/+$/, '');
Expand Down
2 changes: 1 addition & 1 deletion lib/geckodriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ process.env.PATH += path.delimiter + path.join(__dirname, '..');
exports.path = process.platform === 'win32' ? path.join(__dirname, '..', 'geckodriver.exe') : path.join(__dirname, '..', 'geckodriver');

// specify the version of geckodriver
exports.version = process.env.GECKODRIVER_VERSION || '0.28.0';
exports.version = process.env.GECKODRIVER_VERSION || '0.29.0';

exports.start = function(args) {
exports.defaultInstance = require('child_process').execFile(exports.path, args);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "geckodriver",
"version": "1.21.1",
"version": "1.22.0",
"description": "Downloader for https://github.com/mozilla/geckodriver/releases",
"scripts": {
"test": "ava",
Expand Down
2 changes: 1 addition & 1 deletion test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ test.cb('properly extracts', t => {

test('programmatic usage', t => {
var driver = require('../lib/geckodriver')
t.is(driver.version, '0.28.0')
t.is(driver.version, '0.29.0')
});