Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set connection details in selenium-standalone properly #5173

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

Fixes an issue where setting the @wdio/selenium-standalone-server would start the session but fails with every consecutive request. This happens because we would usually default to WebDriver default connection values http://localhost:4444. In v6 we don't do this anymore since it is possible to run tests straight with Puppeteer.

As solution the service will implicitly set default WebDriver connection values if it is being used (for all capabilities).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 30, 2020
@christian-bromann christian-bromann requested a review from a team March 30, 2020 12:24
@christian-bromann christian-bromann merged commit 6444414 into master Mar 30, 2020
@christian-bromann christian-bromann deleted the cb-fix-connection-setting branch March 30, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants