Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for feature description in reporters #5218

Merged
merged 3 commits into from
Apr 6, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

This patch propagates the description property to the suite class so it can be used in reporters.

fixes: #4942

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

If you run the Cucumber example from the repo the spec reporter now outputs:

Screenshot 2020-04-06 at 14 23 12

(see description of feature file in grey)

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Apr 6, 2020
@christian-bromann christian-bromann requested a review from a team April 6, 2020 12:30
@christian-bromann christian-bromann merged commit f180150 into master Apr 6, 2020
@christian-bromann christian-bromann deleted the cb-description-support branch April 6, 2020 15:47
@christian-bromann christian-bromann added the backport-requested PRs with this label are considered to be applied to the last maintained version label Apr 7, 2020
@christian-bromann christian-bromann removed the backport-requested PRs with this label are considered to be applied to the last maintained version label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description of scenarios not exposed in reporter
2 participants