Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workshop video to contribute page #5574

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Add workshop video to contribute page #5574

merged 1 commit into from
Jul 6, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

Adding the Collab Summit workshop video to the Contributing page.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Jul 6, 2020
@christian-bromann christian-bromann requested a review from a team July 6, 2020 11:56
klamping
klamping approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@klamping klamping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@christian-bromann christian-bromann merged commit 94fbb6e into master Jul 6, 2020
@christian-bromann christian-bromann deleted the cb-embed-workshop branch July 6, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klamping klamping klamping approved these changes

Assignees
No one assigned
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christian-bromann @klamping