Fix missing mocha test hooks in a junit report #5812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
After upgrading to wdio 6 (and mocha 8), we have noticed that junit report doesn't contain failed mocha hooks anymore.
It looks like mocha test hook titles are changed in mocha 8. Previously, it is used to be
"before all" hook"
,"after all" hook
, etc, but now it is"before all" hook for "test name"
.This PR fixes the condition used to add
failed
hooks to a generated junit report. It also addsbeforeEach/afterEach
hooks to the junit report.Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers