Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial package.json for npm. #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

trusktr
Copy link

@trusktr trusktr commented Jan 6, 2015

No description provided.

@trusktr
Copy link
Author

trusktr commented Jan 6, 2015

We'll add commits here until it's ready. Obviously don't merge until then. We can keep it rebased on top of master.

@trusktr
Copy link
Author

trusktr commented Jan 6, 2015

npm init automatically made the description be the image.

@trusktr
Copy link
Author

trusktr commented Jan 6, 2015

In that last commit, the cesiumjs dependency is from npm, from upstream agi. Let me know if it should be changed to the klokantech one.

@trusktr
Copy link
Author

trusktr commented Jan 6, 2015

That's about as much as I can do right now. I don't know enough about what's happening with all the goog stuff yet (I have 0 experience with closure). Good thing at my job there's a bunch of closure guys. Maybe I can ask them for some help. It seems possible to make the smallest amount of changes by using nclosure. The other option would be to abandon closure and convert to vanilla nodejs.

@trusktr
Copy link
Author

trusktr commented Jan 11, 2015

@klokan, @wajatimur might be able to give us some pointers: wajatimur/node-phonenumber#4

@klokan klokan mentioned this pull request Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant