-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronous validation in getMappedRange #64
Comments
(Which is especially problematic for the overlapping-range validation.) |
IMHO the overlapping range validation should be on the Blink side only, because it stems from limitations of |
Good point. Perhaps no issue here then. |
from last week's meeting: At least the safe Rust API will keep this validation because it's required for Rust safety guarantees. wgpu-core and the C API don't necessarily have to, still. |
Do we have an explanation of why this is needed for the Rust safety guarantees? It seems it would only be to get mutable ranges? |
We didn't specifically talk about const ranges, maybe for const ranges overlaps are fine? @cwfitzgerald |
Correct, const overlaps are fine, mutable overlaps are not. |
In June we had concluded:
However we discussed this more today in the broader context of reporting synchronous errors and came to a simpler conclusion:
|
Fixes webgpu-native#255 Fixes (again?) webgpu-native#291 Issue webgpu-native#225 Fixes webgpu-native#64
Fixes webgpu-native#255 Fixes (again?) webgpu-native#291 Issue webgpu-native#225 Fixes webgpu-native#64
Fixes webgpu-native#255 Fixes (again?) webgpu-native#291 Issue webgpu-native#225 Fixes webgpu-native#64
How should synchronous validation errors be exposed in getMappedRange? It can return null, but that doesn't tell the caller what went wrong. This would probably be fine, except e.g. Chromium needs to know what string to attach to the DOMException it generates. To do that now it needs to duplicate all of the validation that's already in getMappedRange.
The text was updated successfully, but these errors were encountered: