Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Separate the compat data into its own utils package #3035

Closed
molant opened this issue Sep 26, 2019 · 5 comments · Fixed by #3106
Closed

[Feature] Separate the compat data into its own utils package #3035

molant opened this issue Sep 26, 2019 · 5 comments · Fixed by #3106
Assignees
Milestone

Comments

@molant
Copy link
Member

molant commented Sep 26, 2019

The browser compat data gets updated fairly often. Right now our compat util lives in utils which is used virtually by all hints and thus causing all the packages to update everytime there's something new.

We should take it to a different package to avoid releasing that often.

This will be a breaking change on utils.

@molant
Copy link
Member Author

molant commented Sep 29, 2019

Adding @atopal as we talked about this earlier today 🙂

@molant
Copy link
Member Author

molant commented Oct 7, 2019

Going to take a look at this now.

@molant molant self-assigned this Oct 7, 2019
molant added a commit to molant/hint that referenced this issue Oct 10, 2019
@molant molant mentioned this issue Oct 10, 2019
4 tasks
molant added a commit to molant/hint that referenced this issue Oct 10, 2019
molant added a commit to molant/hint that referenced this issue Oct 11, 2019
@Elchi3
Copy link

Elchi3 commented Oct 11, 2019

We should take it to a different package to avoid releasing that often.

How often do you plan to update the data? Have users reported issues with outdated information?

@molant
Copy link
Member Author

molant commented Oct 11, 2019

How often do you plan to update the data?

Dependabot runs once per week and our plans is to publish once every other week more or less.

The issue is that the compat data is in the utils package that is virtually used by all our other packages. Updating utils means all the other packages (70+) need to be bumped and published to npm. By separating the compat data to a separate package only 4-5 packages will need to be published if only the compat data changes.

The interesting part of this change is that we are documenting a lot more how we query the browser compat data. Please take a look and let us know if this could be useful for other projects using that data.

@Elchi3
Copy link

Elchi3 commented Oct 11, 2019

Ah, got it now. Thank you for elaborating! :)

The interesting part of this change is that we are documenting a lot more how we query the browser compat data. Please take a look and let us know if this could be useful for other projects using that data.

Yes, awesome! We should considers this if / when we start any work on mdn/browser-compat-data#4106

@molant molant removed the breaking label Oct 11, 2019
@antross antross modified the milestones: 1910-1, 1910-2 Oct 11, 2019
molant added a commit to molant/hint that referenced this issue Oct 14, 2019
molant added a commit to molant/hint that referenced this issue Oct 14, 2019
molant added a commit to molant/hint that referenced this issue Oct 14, 2019
molant added a commit to molant/hint that referenced this issue Oct 15, 2019
molant added a commit to molant/hint that referenced this issue Oct 16, 2019
molant added a commit to molant/hint that referenced this issue Oct 16, 2019
molant added a commit to molant/hint that referenced this issue Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants