fix: add check for binary files.

webiny · Oct 26, 2019 · b201222 · b201222
1 parent 4a6a25f
commit b201222
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/cli/create/template/apps/site/handler/handler.js b/packages/cli/create/template/apps/site/handler/handler.js
@@ -1,6 +1,7 @@
 const fs = require("fs");
 const path = require("path");
 const mime = require("mime-types");
+const isUtf8 = require("isutf8");
 
 const createResponse = ({ type, body, isBase64Encoded, headers }) => {
     return {
@@ -20,7 +21,7 @@ module.exports.handler = async event => {
     let type = mime.lookup(key);
     let isBase64Encoded = false;
 
-    if(key.endsWith("undefined")) {
+    if (key.endsWith("undefined")) {
         return createResponse({
             type,
             body: "",
@@ -43,8 +44,6 @@ module.exports.handler = async event => {
 
     const filePath = path.resolve(key);
 
-    // TODO: check if file should be base64 encoded (binary files)
-
     try {
         let buffer = await new Promise((resolve, reject) => {
             fs.readFile(filePath, (err, data) => {
@@ -53,6 +52,7 @@ module.exports.handler = async event => {
             });
         });
 
+        isBase64Encoded = !isUtf8(buffer);
         const headers = {};
 
         if (key.includes("static")) {

diff --git a/packages/cli/create/template/apps/site/package.json b/packages/cli/create/template/apps/site/package.json
@@ -19,6 +19,7 @@
     "cross-fetch": "^3.0.2",
     "dotenv": "^8.1.0",
     "env-cmd": "^9.0.3",
+    "isutf8": "^2.1.0",
     "react-apollo": "^3.1.0",
     "react-app-env": "^1.2.3",
     "react-helmet": "^5.2.0",