Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): Toast component #4249

Merged
merged 22 commits into from
Nov 11, 2024
Merged

feat(admin-ui): Toast component #4249

merged 22 commits into from
Nov 11, 2024

Conversation

leopuleo
Copy link
Contributor

@leopuleo leopuleo commented Sep 4, 2024

This PR adds the Toast component to the @webiny/admin-ui package.

We are exporting a props-based flat component based on the following radix component.

The new component is fully compatible with the old Snackbar component, but some refactoring is needed when UI tokens are defined.

The useSnackbar hook is fully compatible with the new Toast component. Refactoring the hook will be necessary; a separate PR will address it.

Text and Heading

In this PR, we also introduce new text tokens for the Text and Heading components, which are used internally by the Toast component.

@leopuleo leopuleo marked this pull request as ready for review September 4, 2024 08:25
Copy link
Member

@adrians5j adrians5j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments. All in all, looks good.

packages/app-admin/src/base/Admin.tsx Outdated Show resolved Hide resolved
packages/admin-ui/src/Toast/Toast.stories.tsx Outdated Show resolved Hide resolved
@leopuleo leopuleo merged commit 760f8be into feat/new-admin-ui Nov 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants