Page Builder - fixes UI bugs in revisions list #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavel910
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
This PR fixes issues with updating the revisions list and revision content when selecting different revisions from the dropdown menu (see screenshot).
When doing a
publishRevisionmutation, we must requireidandpublishedin the responsedatafields so Apollo client can update its cache. That's, in general, a needed practice, we should avoid not-listing anydatafields when doing updates (unless there is a good reason not to list any of course).Your solution
Added
idandpublishedfields in response data, so Apollo can update its cache. I also added thekeyprop to theRenderElementcomponent, with the value of currently selected revisionid, so the revision content gets re-rendered when selecting different revisions (packages/app-page-builder/src/admin/plugins/pageDetails/previewContent/PagePreview.js:63).How Has This Been Tested?
Manual testing.
Screenshots (if relevant):
List will now update correctly when doing changes in page builder. The content of active revision will also change when selecting different revisions.