Remove empty paymentError from state

webkom · Apr 21, 2020 · 4b6dee2 · 4b6dee2
1 parent 3e81f2e
commit 4b6dee2
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/app/reducers/registrations.js b/app/reducers/registrations.js
@@ -39,9 +39,13 @@ export default createEntityReducer({
           }
           newState.byId[registration.id] = {
             ...omit(newState.byId[registration.id], 'unregistrationDate'),
-            ...registration,
-            paymentError: (action.meta && action.meta.paymentError) || null
+            ...registration
           };
+          if (action.meta && action.meta.paymentError) {
+            mergeObjects(newState.byId[registration.id], {
+              paymentError: action.meta.paymentError
+            });
+          }
           newState.items = union(newState.items, [registration.id]);
           break;
         }
@@ -76,8 +80,7 @@ export default createEntityReducer({
             return;
           }
           newState.byId[registration.id] = {
-            ...omit(newState.byId[registration.id], 'unregistrationDate'),
-            paymentError: action.payload.response.jsonData.detail
+            ...omit(newState.byId[registration.id], 'unregistrationDate')
           };
           break;
         }