Prevent registration button from moving #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list will be filled with skeletons if there's some events in the redux state from earlier. Also better empty state
ivarnakken
added
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eikhr
approved these changes
Oct 26, 2024
Also improve skeleton components on sidebar. There's still issues with the user grid skeleton, but that can be saved for later :)
ivarnakken
force-pushed
the
events-skeletons
branch
from
bff18b5
to
83aff05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also fix and improve skeleton components on frontpage and event detail sidebar
Result
Screen.Recording.2024-10-26.at.16.50.51.mov
Testing
It's difficult to reproduce the button move on dev fro some reason - might have something to do with the websocket
Resolves ABA-1148