Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support toast types #5108

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Support toast types #5108

merged 2 commits into from
Oct 29, 2024
+51 −24

Conversation

ivarnakken
Copy link
Member

Description

Much faster and better feedback. Currently only support success and error (and the default undefined) - I don't think we'll need any more.

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Before After

Testing

  • I have thoroughly tested my changes.

See images above.

Resolves ABA-1147

@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review new-feature Pull requests that introduce a new feature labels Oct 26, 2024
@ivarnakken ivarnakken requested review from eikhr and a team October 26, 2024 18:40
@ivarnakken ivarnakken self-assigned this Oct 26, 2024
@linear Linear
Copy link

linear bot commented Oct 26, 2024

ABA-1147 Update toasts to support types such as success and error

@vercel Vercel
Copy link

vercel bot commented Oct 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2024 8:08pm

eikhr
eikhr approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

@ivarnakken ivarnakken force-pushed the toast-retouch branch 3 times, most recently from 0f19fa7 to 83d5e75 Compare October 26, 2024 19:58
@ivarnakken ivarnakken added types Pull requests that improve or fix types approved Pull requests that have been approved labels Oct 26, 2024
@ivarnakken
Support toast types
03bc3a4 
Currently only `success` and `error` (and the default `undefined`) - I don't think we'll need any more
@ivarnakken
Style success and danger toasts
0e0d255
ShaileshS1702
ShaileshS1702 reviewed Oct 27, 2024
View reviewed changes
Copy link
Contributor

@ShaileshS1702 ShaileshS1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition

@ivarnakken ivarnakken merged commit 6c9c22a into master Oct 29, 2024
6 checks passed
@ivarnakken ivarnakken deleted the toast-retouch branch October 29, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshS1702 ShaileshS1702 ShaileshS1702 left review comments

@eikhr eikhr eikhr approved these changes

Assignees

@ivarnakken ivarnakken

Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features new-feature Pull requests that introduce a new feature review-needed Pull requests that need review types Pull requests that improve or fix types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivarnakken @eikhr @ShaileshS1702