Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump redux-mock-store from 1.5.4 to 1.5.5 #5113

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2024

Bumps redux-mock-store from 1.5.4 to 1.5.5.

Release notes

Sourced from redux-mock-store's releases.

v1.5.5 - Deprecation

This patch release deprecates the configureStore method, as this package does not align with the Redux team's recommended testing practices. Instead, we recommend testing with a real store.

Testing with a mock store leads to potentially confusing behaviour, such as state not updating when actions are dispatched. Additionally, it's a lot less useful to assert on the actions dispatched rather than the observable state changes.

You can test the entire combination of action creators, reducers, and selectors in a single test, for example:

it('should add a todo', () => {
  const store = makeStore() // a user defined reusable store factory
store.dispatch(addTodo('Use Redux'))
expect(selectTodos(store.getState())).toEqual([
{ text: 'Use Redux', completed: false }
])
})

This avoids common pitfalls of testing each of these in isolation, such as mocked state shape becoming out of sync with the actual application.

legacy_configureStore

We recognise that for many codebases, migration will be a major effort that some may not be able to allocate time for. The @deprecated tag is just a visual strikethrough, but some tools will add extra warnings when it is used.

We now have a legacy_configureStore export (similar to legacy_createStore in Redux core) which is the same function but without this tag. You can change any imports to use this if the deprecation notice presents significant issues for you.

- import configureStore from "redux-mock-store"
+ import { legacy_configureStore as configureStore } from "redux-mock-store"
// or

import { configureStore } from "redux-mock-store"


import { legacy_configureStore as configureStore } from "redux-mock-store"

Full Changelog: reduxjs/redux-mock-store@v1.5.4...v1.5.5

Commits
Maintainer changes

This version was pushed to npm by eskimojo, a new releaser for redux-mock-store since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @webkom-R2D2.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 28, 2024
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 0:15am

Copy link
Collaborator

@webkom-R2D2 webkom-R2D2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 28, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@ivarnakken
Copy link
Member

@dependabot rebase

Bumps [redux-mock-store](https://github.com/arnaudbenard/redux-mock-store) from 1.5.4 to 1.5.5.
- [Release notes](https://github.com/arnaudbenard/redux-mock-store/releases)
- [Commits](reduxjs/redux-mock-store@v1.5.4...v1.5.5)

---
updated-dependencies:
- dependency-name: redux-mock-store
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/redux-mock-store-1.5.5 branch from 887e891 to 4c49209 Compare October 29, 2024 12:15
Copy link
Collaborator

@webkom-R2D2 webkom-R2D2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@ivarnakken ivarnakken self-assigned this Oct 30, 2024
@ivarnakken
Copy link
Member

#5117

@ivarnakken ivarnakken closed this Oct 30, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 30, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@ivarnakken ivarnakken deleted the dependabot/npm_and_yarn/redux-mock-store-1.5.5 branch October 30, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants