Update waiting list placement calculation for more performant backend #5141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Appearently my code in webkom/lego#3642 caused "significant performance issues" and "increased loading times" on the event detail page. This is true, my bad.
I believe the issue getting the fairly expensive inherited groups for each person in the waiting list. Instead we can just get child-groups for all the applicable groups in the pools. This should be cheaper because there are fewer pools.
Result
No visual changes
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ... (either GitHub issue or Linear task)