Add semester auto select to interest page #5165
Open
+69
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ivarnakken
approved these changes
Nov 6, 2024
Comment on lines
244
to
245
| value: Number(currentCompanySemester?.id) ?? 9999, | ||
| year: currentCompanySemester?.year ?? 9999, |
There was a problem hiding this comment.
💀 why not just the current year?
There was a problem hiding this comment.
If currentCompanySemester is undefined (which it really shouldn't since the default option is the current semester), the input should default to "Vis alle semestre". Looking at the old implementation, the value defaulted to '', but year is now a number. Would Number(currentCompanySemester?.year) be better?
Comment on lines
+83
to
+84
| T, | ||
| Option extends { label: string; value: T }, |
There was a problem hiding this comment.
It's maybe not the best solution, but it fixes typescript errors when value is not a number (the most common case afaik). I assume value: any would not be better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the selected semester under company interest the current semester by default.
Result
Screencast.From.2024-11-06.21-14-27.mp4
Testing
Resolves ABA-1048