Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Can't scoll on ConfigServer Security Firewall (CSF) module #513

Closed
ghost opened this issue Jul 21, 2016 · 14 comments
Closed

Theme: Can't scoll on ConfigServer Security Firewall (CSF) module #513

ghost opened this issue Jul 21, 2016 · 14 comments

Comments

@ghost
Copy link

ghost commented Jul 21, 2016

Hi, on latest version of webmin and authentic, it's not possible to scroll on CSF module.

Sometimes possible when you reload the main page, but, if you go into "Firewall Configuration" it is not possible at all.

@iliajie
Copy link
Collaborator

iliajie commented Jul 21, 2016

Which version do you consider to be latest?

@ghost
Copy link
Author

ghost commented Jul 21, 2016

Webmin 1.801
Authentic Theme 17.84

@iliajie iliajie changed the title Can't scoll on CSF Module Theme: Can't scoll on ConfigServer Security Firewall (CSF) module Jul 21, 2016
@iliajie
Copy link
Collaborator

iliajie commented Jul 21, 2016

The latest version is 18.03.

Upgrade the theme manually to the version 18.03 as Webmin currently can't handle GitHub connections.

How to upgrade the theme manually see this: #505

@ghost
Copy link
Author

ghost commented Jul 21, 2016

Same thing on 18.03

@iliajie
Copy link
Collaborator

iliajie commented Jul 21, 2016

No, it's fixed in 18.03. Make sure to clear browser's cache and restart Webmin.

@iliajie iliajie added bug and removed help wanted labels Jul 22, 2016
@iliajie
Copy link
Collaborator

iliajie commented Jul 22, 2016

Oh, I could accidentally reproduce no scroll issue in Firefox on some pages of ConfigServer Security and Firewall.

Version 18.04 has just been re-uploaded and fixes the issue. Please upgrade!!

How to upgrade in case of Webmin <1.810.

@kreationnext
Copy link

Well done on this one too.

It looks a bit congested now. If you can add some margin to the elements like 3px or so, It will get some pro look. And you can also use the css of the buttons [like green, orange, etc] to give some colors to it.

It will make the buttons more clickable. :D

@iliajie
Copy link
Collaborator

iliajie commented Jul 23, 2016

Color and margin/padding to buttons to the main page?

@kreationnext
Copy link

to the main page: margin/padding.
to all pages: Color for buttons

On Sun, Jul 24, 2016 at 1:45 AM, Ilia Rostovtsev [email protected]
wrote:

Color and margin/padding to buttons to the main page?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#513 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQIUXUeh-Gc8EECVOc0fCcd_maooOpV0ks5qYnZtgaJpZM4JSGfb
.

@iliajie
Copy link
Collaborator

iliajie commented Jul 23, 2016

OK, sounds good.

@iliajie
Copy link
Collaborator

iliajie commented Jul 24, 2016

@kreationnext Ok, re-install the theme, I have updated version 18.04 with mentioned improvements and some bug fixes!

Like it more this way? ;)

@kreationnext
Copy link

ya! It looks great! but something I would like to add.
In the main page the general button color is white with grey border and
there is a hover effect too.

You have changed the button color of a few buttons only but not others.
lets take a css[only for csf]
and apply

input[type=submit] {
color: #fff;
background: #156BB0;
border: #999;
width: 200px;
}
input[type=submit]:hover {
background: #488BF9;
}

and for small buttons [like edit] you reduce the width [say 60px]

On Sun, Jul 24, 2016 at 3:30 PM, Ilia Rostovtsev [email protected]
wrote:

@kreationnext https://github.com/kreationnext Ok, re-install the theme,
I have updated version 18.04 with mentioned improvements and some bug fixes!

Like it more this way? ;)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#513 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQIUXRhy8-OrWhHU_-LEHff7N4yTHTLFks5qYzfHgaJpZM4JSGfb
.

@kreationnext
Copy link

I only mean for the first page. rest of them are ok

On Sun, Jul 24, 2016 at 3:30 PM, Ilia Rostovtsev [email protected]
wrote:

@kreationnext https://github.com/kreationnext Ok, re-install the theme,
I have updated version 18.04 with mentioned improvements and some bug fixes!

Like it more this way? ;)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#513 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQIUXRhy8-OrWhHU_-LEHff7N4yTHTLFks5qYzfHgaJpZM4JSGfb
.

@iliajie
Copy link
Collaborator

iliajie commented Jul 24, 2016

Ok, what I can offer you is to add the the following code to Theme Extensions and it will survive updates and apply any CSS you need on CSF - But you will need to again re-install the theme, as this feature has just been added for CSF. 😆

/* CSF Index page buttons fixed width/style. Start. */
.csf .panel-body > table ~ table.csf-table.table.table-striped.table-condensed[align="center"][border="0"][cellpadding="4"][cellspacing="0"] tbody tr.csf-tr td select,
.csf .panel-body > table ~ table.csf-table.table.table-striped.table-condensed[align="center"][border="0"][cellpadding="4"][cellspacing="0"] tbody tr.csf-tr td input[type="submit"]:not([value="Edit"]) {
    width: 200px  !important;
}

@iliajie iliajie closed this as completed Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants