Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare key as a var so it complies with strict mode #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liuhelen10
Copy link

@liuhelen10 liuhelen10 commented Dec 11, 2017

Fixes issue defined here

@liuhelen10
Copy link
Author

@coreh do you mind reviewing?

@coreh
Copy link
Contributor

coreh commented Dec 11, 2017

Oops! Sorry, hadn't seen your other issue, I've been a bit MiA on GitHub lately. 😕

I'm no longer a member of the webmodules org, so I no longer have commit access :(

I was going to hand over the npm package over to @wilddeer, the original author of the lib, but looks like I dropped the ball on that one too. 😕 Looks like he published the updated package under stickyfilljs. Here's his repo: https://github.com/wilddeer/stickyfill/

Is it still affected by this issue?

@wilddeer if you'd like I can still make that transfer

@liuhelen10
Copy link
Author

Unfortunately the package owned by @wilddeer breaks when included in apps that use server-side rendering, so i've been continuing to use this one.

What's the best next step @coreh ? Is this package no longer going to be maintained? Should I open a new issue against https://github.com/wilddeer/stickyfill/ ?

@coreh
Copy link
Contributor

coreh commented Dec 12, 2017

@liuhelen10 I've merged this locally on my machine and — since I still have owner access to the package — published version 1.1.1-strict to NPM.

I didn't go for, say, 1.1.2 because there is already a version with that number from the original author, and it wouldn't be exactly the same as this patched version. (Perhaps they still want to publish it under the actual stickyfill name, and I don't want to "use up" that version).

@wilddeer I've added you as an owner to the stickyfill package on npm. I guess better late than never? 🙇 Sorry for taking so long

@liuhelen10
Copy link
Author

liuhelen10 commented Dec 12, 2017

great thank you!! so is this npm installable now? i don't see it in the release log

@coreh
Copy link
Contributor

coreh commented Dec 12, 2017

Yep. npm install --save [email protected] from your project should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants