Fix error on resource assertion if message has a second placeholder
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I came to the conclusion a bespoke test was needed but I might have missed something. |
Prior to this change code such as `Assert::resource(null, 'stream', 'Got: %s, type: %s')` would fail as the second placeholder was only passed into `sprintf()` if the value supplied is a resource. Test I've added without the code change fails with: ``` 1) Webmozart\Assert\Tests\AssertTest::testResourceOfTypeCustomMessage Failed asserting that exception of type "ArgumentCountError" matches expected exception "\InvalidArgumentException". Message was: "3 arguments are required, 2 given" at <snip>/src/Assert.php:255 <snip>/tests/AssertTest.php:827 ```
cs278
force-pushed
the
fix-resource-assertion
branch
from
214460c
to
73bfe48
Compare
|
Great to see some activity here again, I've rebased this to pickup the CI changes. |
shadowhand
approved these changes
Oct 16, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change code such as
Assert::resource(null, 'stream', 'Got: %s, type: %s')would fail asthe second placeholder was only passed into
sprintf()if the valuesupplied is a resource.
Test I've added without the code change fails with: