refactor: nodejs v10 dropped (#606)

BREAKING CHANGE: minimum supported `Node.js` version is `12.13.0`
webpack-contrib · May 21, 2021 · beff64e · beff64e
1 parent 3a1139e
commit beff64e
Show file tree

Hide file tree

Showing 11 changed files with 2,106 additions and 1,867 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -29,10 +29,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Use Node.js ${{ env.node-version }}
+      - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v1
         with:
-          node-version: ${{ env.node-version }}
+          node-version: ${{ matrix.node-version }}
 
       - name: Use latest NPM
         run: sudo npm i -g npm
@@ -55,7 +55,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        node-version: [10.x, 12.x, 14.x]
+        node-version: [12.x, 14.x, 16.x]
         webpack-version: [latest]
 
     runs-on: ${{ matrix.os }}

diff --git a/.husky/commit-msg b/.husky/commit-msg
@@ -1,4 +1,4 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-npx commitlint --edit $1
+npx --no-install commitlint --edit $1
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1,4 +1,4 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-npx lint-staged
+npx --no-install lint-staged
diff --git a/babel.config.js b/babel.config.js
@@ -10,7 +10,7 @@ module.exports = (api) => {
         "@babel/preset-env",
         {
           targets: {
-            node: "10.13.0",
+            node: "12.13.0",
           },
         },
       ],

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
   },
   "main": "dist/cjs.js",
   "engines": {
-    "node": ">= 10.13.0"
+    "node": ">= 12.13.0"
   },
   "scripts": {
     "start": "npm run build -- -w",
@@ -31,8 +31,7 @@
     "pretest": "npm run lint",
     "test": "npm run test:coverage",
     "prepare": "husky install && npm run build",
-    "release": "standard-version",
-    "defaults": "webpack-defaults"
+    "release": "standard-version"
   },
   "files": [
     "dist"
@@ -42,38 +41,38 @@
   },
   "dependencies": {
     "fast-glob": "^3.2.5",
-    "glob-parent": "^5.1.1",
+    "glob-parent": "^6.0.0",
     "globby": "^11.0.3",
     "normalize-path": "^3.0.0",
     "p-limit": "^3.1.0",
     "schema-utils": "^3.0.0",
     "serialize-javascript": "^5.0.1"
   },
   "devDependencies": {
-    "@babel/cli": "^7.13.10",
-    "@babel/core": "^7.13.10",
-    "@babel/preset-env": "^7.13.12",
-    "@commitlint/cli": "^12.0.1",
-    "@commitlint/config-conventional": "^12.0.1",
+    "@babel/cli": "^7.14.3",
+    "@babel/core": "^7.14.3",
+    "@babel/preset-env": "^7.14.2",
+    "@commitlint/cli": "^12.1.4",
+    "@commitlint/config-conventional": "^12.1.4",
     "@webpack-contrib/eslint-config-webpack": "^3.0.0",
     "babel-jest": "^26.6.3",
-    "cross-env": "^7.0.2",
+    "cross-env": "^7.0.3",
     "del": "^6.0.0",
     "del-cli": "^3.0.1",
-    "eslint": "^7.22.0",
-    "eslint-config-prettier": "^8.1.0",
-    "eslint-plugin-import": "^2.22.1",
-    "file-loader": "^6.1.1",
-    "husky": "^5.2.0",
+    "eslint": "^7.26.0",
+    "eslint-config-prettier": "^8.3.0",
+    "eslint-plugin-import": "^2.23.2",
+    "file-loader": "^6.2.0",
+    "husky": "^6.0.0",
     "is-gzip": "^2.0.0",
     "jest": "^26.6.3",
-    "lint-staged": "^10.5.4",
-    "memfs": "^3.2.0",
+    "lint-staged": "^11.0.0",
+    "memfs": "^3.2.2",
     "mkdirp": "^1.0.4",
     "npm-run-all": "^4.1.5",
-    "prettier": "^2.1.2",
-    "standard-version": "^9.1.1",
-    "webpack": "^5.27.2"
+    "prettier": "^2.3.0",
+    "standard-version": "^9.3.0",
+    "webpack": "^5.37.1"
   },
   "keywords": [
     "webpack",

diff --git a/src/index.js b/src/index.js
@@ -71,12 +71,8 @@ class CopyPlugin {
 
   static getContentHash(compiler, compilation, source) {
     const { outputOptions } = compilation;
-    const {
-      hashDigest,
-      hashDigestLength,
-      hashFunction,
-      hashSalt,
-    } = outputOptions;
+    const { hashDigest, hashDigestLength, hashFunction, hashSalt } =
+      outputOptions;
     const hash = compiler.webpack.util.createHash(hashFunction);
 
     if (hashSalt) {
@@ -567,13 +563,8 @@ class CopyPlugin {
                 contentHash,
               },
             };
-            const {
-              path: interpolatedFilename,
-              info: assetInfo,
-            } = compilation.getPathWithInfo(
-              normalizePath(result.filename),
-              data
-            );
+            const { path: interpolatedFilename, info: assetInfo } =
+              compilation.getPathWithInfo(normalizePath(result.filename), data);
 
             result.info = { ...result.info, ...assetInfo };
             result.filename = interpolatedFilename;
@@ -715,19 +706,14 @@ class CopyPlugin {
                           transformedAsset.data
                         );
 
-                        const {
-                          path: interpolatedFilename,
-                          info: assetInfo,
-                        } = compilation.getPathWithInfo(
-                          normalizePath(item.to),
-                          {
+                        const { path: interpolatedFilename, info: assetInfo } =
+                          compilation.getPathWithInfo(normalizePath(item.to), {
                             contentHash,
                             chunk: {
                               hash: contentHash,
                               contentHash,
                             },
-                          }
-                        );
+                          });
 
                         transformedAsset.filename = interpolatedFilename;
                         transformedAsset.info = assetInfo;

diff --git a/test/CopyPlugin.test.js b/test/CopyPlugin.test.js
@@ -1,7 +1,10 @@
 import path from "path";
 
+// eslint-disable-next-line import/no-extraneous-dependencies
 import webpack from "webpack";
+// eslint-disable-next-line import/no-extraneous-dependencies
 import del from "del";
+// eslint-disable-next-line import/no-extraneous-dependencies
 import { createFsFromVolume, Volume } from "memfs";
 
 import CopyPlugin from "../src/index";

diff --git a/test/helpers/getCompiler.js b/test/helpers/getCompiler.js
@@ -1,6 +1,8 @@
 import path from "path";
 
+// eslint-disable-next-line import/no-extraneous-dependencies
 import webpack from "webpack";
+// eslint-disable-next-line import/no-extraneous-dependencies
 import { createFsFromVolume, Volume } from "memfs";
 
 export default (config = {}) => {

diff --git a/test/to-option.test.js b/test/to-option.test.js
@@ -961,8 +961,7 @@ describe("to option", () => {
       patterns: [
         {
           from: "directory/directoryfile.*",
-          to:
-            "[path][base]-new-[name][ext].[contenthash].[hash]-[fullhash][ext]--[unknown]",
+          to: "[path][base]-new-[name][ext].[contenthash].[hash]-[fullhash][ext]--[unknown]",
         },
       ],
     })

diff --git a/test/toType-option.test.js b/test/toType-option.test.js
@@ -45,8 +45,7 @@ describe("toType option", () => {
       patterns: [
         {
           from: "directory/directoryfile.*",
-          to:
-            "[path][base]-new-[name][ext].[contenthash].[hash]-[fullhash][ext]",
+          to: "[path][base]-new-[name][ext].[contenthash].[hash]-[fullhash][ext]",
           toType: "template",
         },
       ],