Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop node v12 #691

Merged
merged 3 commits into from
May 17, 2022
Merged

build: drop node v12 #691

merged 3 commits into from
May 17, 2022

Conversation

snitin315
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #691 (af8c9d2) into master (a2b1f19) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #691   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files           2        2           
  Lines         397      397           
  Branches      119      119           
=======================================
  Hits          358      358           
  Misses         38       38           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b1f19...af8c9d2. Read the comment docs.

babel.config.js Outdated
@@ -12,7 +12,7 @@ module.exports = (api) => {
exclude:
process.env.NODE_ENV === "test" ? [] : ["proposal-dynamic-import"],
targets: {
node: "12.20.0",
node: "14.16.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snitin315 Let's fix it to 14.15.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait done, updated deps too.

package.json Outdated
@@ -14,7 +14,7 @@
"main": "dist/index.js",
"types": "types/index.d.ts",
"engines": {
"node": ">= 12.20.0"
"node": ">= 14.16.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@alexander-akait alexander-akait merged commit 675c676 into master May 17, 2022
@alexander-akait alexander-akait deleted the drop-node-12 branch May 17, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants