-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export default getLocalIdent
#1046
feat: export default getLocalIdent
#1046
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 10 10
Lines 484 484
Branches 150 150
=======================================
Hits 475 475
Misses 8 8
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we should do that, because we change algorithm often, so it will be problem with released and require for us do major release on each change
I understand. May be adding option for filtering files will be better solution? |
Which files? |
As in example, I've bunch of legacy files, which not supposed to use css-modules. UPD: |
Other good solution what we can implement #994 |
We can implement that right now ( |
Oh, it's cool. I'll try to help implement that. |
This PR contains a:
Motivation / Use-Case
For example, use default
getLocalIdent
, but override it's behavior for specific files: