Use devtool and sourceMap flag from webpack config #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of needing to apply the sourceMap query parameter generate if a devtool option is specified in the webpack config.
|
Seems reasonable... @sokra why did you use a query param? |
|
This It injects the SourceMap to the resulting bundle (instead of generating a separate SourceMap file). You can use it without the SourceMap devtool. It is not related to the devtool at all. So I would better leave it opt-in. Currently it's only working correctly with |
mtscout6
added a commit
to mtscout6/extract-text-webpack-plugin
that referenced
this pull request
Feb 25, 2015
Source-maps do not work for CSS when you base64 encode them, yet it would be nice to to facilitate dynamically applying source-maps using `webpack -d`. This will apply the sourceMap query param to the css-loader if a devtool option is selected in the webpack config. Relates to webpack-contrib/less-loader#36 Relates to webpack-contrib/css-loader#40
mtscout6
added a commit
to mtscout6/extract-text-webpack-plugin
that referenced
this pull request
Feb 25, 2015
Source-maps do not work for CSS when you base64 encode them, yet it would be nice to to facilitate dynamically applying source-maps using `webpack -d`. This will apply the sourceMap query param to the css-loader if a devtool option is selected in the webpack config. Relates to webpack-contrib/less-loader#36 Relates to webpack-contrib/css-loader#40
mtscout6
added a commit
to mtscout6/extract-text-webpack-plugin
that referenced
this pull request
Feb 25, 2015
Source-maps do not work for CSS when you base64 encode them, yet it would be nice to to facilitate dynamically applying source-maps using `webpack -d`. This will apply the sourceMap query param to the css-loader if a devtool option is selected in the webpack config. Relates to webpack-contrib/less-loader#36 Relates to webpack-contrib/css-loader#40
mtscout6
added a commit
to mtscout6/extract-text-webpack-plugin
that referenced
this pull request
Feb 25, 2015
Source-maps do not work for CSS when you base64 encode them, yet it would be nice to to facilitate dynamically applying source-maps using `webpack -d`. This will apply the sourceMap query param to the css-loader if a devtool option is selected in the webpack config. Relates to webpack-contrib/less-loader#36 Relates to webpack-contrib/css-loader#40
mtscout6
added a commit
to mtscout6/extract-text-webpack-plugin
that referenced
this pull request
Feb 25, 2015
Source-maps do not work for CSS when you base64 encode them, yet it would be nice to to facilitate dynamically applying source-maps using `webpack -d`. This will apply the sourceMap query param to the css-loader if a devtool option is selected in the webpack config. Relates to webpack-contrib/less-loader#36 Relates to webpack-contrib/css-loader#40
|
Closing in favor of webpack-contrib/extract-text-webpack-plugin#53 |
jhnns
added a commit
to webpack-contrib/less-loader
that referenced
this pull request
Mar 6, 2015
Not using the `this.sourceMap` flag because css source maps are different @see webpack-contrib/css-loader#40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of needing to apply the sourceMap query parameter generate if a
devtool option is specified in the webpack config.