Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): rm comment, rename const => var #452

Merged
merged 3 commits into from
Mar 12, 2017
Merged

fix(lib): rm comment, rename const => var #452

merged 3 commits into from
Mar 12, 2017

Conversation

michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Mar 12, 2017

@codecov
Copy link

codecov bot commented Mar 12, 2017

Codecov Report

Merging #452 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #452   +/-   ##
======================================
  Coverage    90.7%   90.7%           
======================================
  Files          10      10           
  Lines         398     398           
  Branches       85      85           
======================================
  Hits          361     361           
  Misses         37      37
Impacted Files Coverage Δ
lib/convert-source-map.js 54.92% <ø> (ø)
lib/css-base.js 97.14% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0252643...0c77ea5. Read the comment docs.

Copy link
Contributor

@bebraw bebraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we could drop lib/convert-source-map.js as it was meant as a temporary solution.

@michael-ciniawsky
Copy link
Member Author

@bebraw Is webpack #4458 solved ? The temporary fix was needed, because of problems with the convert-source-map dependency relying on require('fs') internally? I'm all in favour of removing it but how? 😛

@bebraw
Copy link
Contributor

bebraw commented Mar 12, 2017

The problem with #4458 is that webpack might be doing the right thing here. No fs on web. But the bits we need don't rely on fs. I think we may have to wait Tobias to comment in order to know the right fix.

Merge this and push a patch version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module not found: Error: Can't resolve './convert-source-map' -- upgrade from 0.26.4 to 0.27.2
2 participants