-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lib): rm comment, rename const => var #452
fix(lib): rm comment, rename const => var #452
Conversation
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
======================================
Coverage 90.7% 90.7%
======================================
Files 10 10
Lines 398 398
Branches 85 85
======================================
Hits 361 361
Misses 37 37
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we could drop lib/convert-source-map.js
as it was meant as a temporary solution.
@bebraw Is webpack #4458 solved ? The temporary fix was needed, because of problems with the |
The problem with #4458 is that webpack might be doing the right thing here. No Merge this and push a patch version. |
fixes #451 #450 , source-map-loader #34