Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid all escaped characters replaced #917

Merged
merged 5 commits into from
Apr 10, 2019
Merged

fix: avoid all escaped characters replaced #917

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f42f0e
fix: do not replace symbol @ in selectors
alreadyExisted Apr 6, 2019
a0c39eb
fix: avoid all escaped characters replaced
alreadyExisted Apr 8, 2019
81d9f90
test: update snap
alreadyExisted Apr 8, 2019
7ff45c2
style: fix eol-last in css
Apr 9, 2019
925af44
test: update snap
Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 47 additions & 3 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,7 @@ function getLocalIdent(loaderContext, localIdentName, localName, options) {
options
);

return hash
.replace(new RegExp('[^a-zA-Z0-9\\-_\u00A0-\uFFFF]', 'g'), '-')
.replace(/^((-?[0-9])|--)/, '_$1');
return normalizeIdentifier(hash);
}

function getFilter(filter, resourcePath, defaultFilter = null) {
Expand All @@ -107,6 +105,52 @@ function getFilter(filter, resourcePath, defaultFilter = null) {
};
}

function normalizeIdentifier(value) {
const escapedSymbols = [
'~',
'!',
'@',
'#',
'$',
'%',
'&',
'^',
'*',
'(',
')',
'{',
'}',
'[',
']',
'`',
'/',
'=',
'?',
'+',
'\\',
'|',
'-',
'_',
':',
';',
"'",
'"',
',',
'<',
'.',
'>',
];

const identifiersRegExp = new RegExp(
`[^a-zA-Z0-9${escapedSymbols.join('\\')}\\-_\u00A0-\uFFFF]`,
'g'
);

return value
.replace(identifiersRegExp, '-')
.replace(/^((-?[0-9])|--)/, '_$1');
}

export {
getImportPrefix,
getLocalIdent,
Expand Down
203 changes: 196 additions & 7 deletions test/__snapshots__/localIdentName-option.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,16 @@ Array [
:local(.-a0-34a___f) {
color: red;
}
",

:local(.m_x_\\\\@) {
margin-left: auto !important;
margin-right: auto !important;
}

:local(.B\\\\&W\\\\?) {
margin-left: auto !important;
margin-right: auto !important;
}",
"",
],
]
Expand Down Expand Up @@ -78,7 +87,16 @@ Array [
:local(.-a0-34a___f) {
color: red;
}
",

:local(.m_x_\\\\@) {
margin-left: auto !important;
margin-right: auto !important;
}

:local(.B\\\\&W\\\\?) {
margin-left: auto !important;
margin-right: auto !important;
}",
"",
],
]
Expand Down Expand Up @@ -121,7 +139,16 @@ Array [
:local(.-a0-34a___f) {
color: red;
}
",

:local(.m_x_\\\\@) {
margin-left: auto !important;
margin-right: auto !important;
}

:local(.B\\\\&W\\\\?) {
margin-left: auto !important;
margin-right: auto !important;
}",
"",
],
]
Expand Down Expand Up @@ -164,7 +191,16 @@ Array [
:local(.-a0-34a___f) {
color: red;
}
",

:local(.m_x_\\\\@) {
margin-left: auto !important;
margin-right: auto !important;
}

:local(.B\\\\&W\\\\?) {
margin-left: auto !important;
margin-right: auto !important;
}",
"",
],
]
Expand Down Expand Up @@ -207,7 +243,16 @@ Array [
:local(.-a0-34a___f) {
color: red;
}
",

:local(.m_x_\\\\@) {
margin-left: auto !important;
margin-right: auto !important;
}

:local(.B\\\\&W\\\\?) {
margin-left: auto !important;
margin-right: auto !important;
}",
"",
],
]
Expand Down Expand Up @@ -250,7 +295,16 @@ Array [
:local(.-a0-34a___f) {
color: red;
}
",

:local(.m_x_\\\\@) {
margin-left: auto !important;
margin-right: auto !important;
}

:local(.B\\\\&W\\\\?) {
margin-left: auto !important;
margin-right: auto !important;
}",
"",
],
]
Expand Down Expand Up @@ -293,10 +347,145 @@ Array [
:local(.-a0-34a___f) {
color: red;
}
",

:local(.m_x_\\\\@) {
margin-left: auto !important;
margin-right: auto !important;
}

:local(.B\\\\&W\\\\?) {
margin-left: auto !important;
margin-right: auto !important;
}",
"",
],
]
`;

exports[`localIdentName option should use hash prefix: warnings 1`] = `Array []`;

exports[`localIdentName option should сorrectly replace escaped symbols in selector: errors 1`] = `Array []`;

exports[`localIdentName option should сorrectly replace escaped symbols in selector: locals 1`] = `
Object {
"-a0-34a___f": "-a0-34a___f--2nJ5",
"B&W?": "B&W?--1s8i",
"_test": "_test--23te",
"className": "className--1E8H",
"m_x_@": "m_x_@--2G3b",
"someId": "someId--3w7J",
"subClass": "subClass--3lo0",
"test": "test--NW9Y",
}
`;

exports[`localIdentName option should сorrectly replace escaped symbols in selector: module (evaluated) 1`] = `
Array [
Array [
1,
".test--NW9Y {
background: red;
}

._test--23te {
background: blue;
}

.className--1E8H {
background: red;
}

#someId--3w7J {
background: green;
}

.className--1E8H .subClass--3lo0 {
color: green;
}

#someId--3w7J .subClass--3lo0 {
color: blue;
}

.-a0-34a___f--2nJ5 {
color: red;
}

.m_x_\\\\@--2G3b {
margin-left: auto !important;
margin-right: auto !important;
}

.B\\\\&W\\\\?--1s8i {
margin-left: auto !important;
margin-right: auto !important;
}",
"",
],
]
`;

exports[`localIdentName option should сorrectly replace escaped symbols in selector: warnings 1`] = `Array []`;

exports[`localIdentName option should сorrectly replace symbol @ in selector: errors 1`] = `Array []`;

exports[`localIdentName option should сorrectly replace symbol @ in selector: locals 1`] = `
Object {
"-a0-34a___f": "-a0-34a___f--2nJ5",
"B&W?": "B&W?--1s8i",
"_test": "_test--23te",
"className": "className--1E8H",
"m_x_@": "m_x_@--2G3b",
"someId": "someId--3w7J",
"subClass": "subClass--3lo0",
"test": "test--NW9Y",
}
`;

exports[`localIdentName option should сorrectly replace symbol @ in selector: module (evaluated) 1`] = `
Array [
Array [
1,
".test--NW9Y {
background: red;
}

._test--23te {
background: blue;
}

.className--1E8H {
background: red;
}

#someId--3w7J {
background: green;
}

.className--1E8H .subClass--3lo0 {
color: green;
}

#someId--3w7J .subClass--3lo0 {
color: blue;
}

.-a0-34a___f--2nJ5 {
color: red;
}

.m_x_\\\\@--2G3b {
margin-left: auto !important;
margin-right: auto !important;
}

.B\\\\&W\\\\?--1s8i {
margin-left: auto !important;
margin-right: auto !important;
}",
"",
],
]
`;

exports[`localIdentName option should сorrectly replace symbol @ in selector: warnings 1`] = `Array []`;
10 changes: 10 additions & 0 deletions test/fixtures/modules/localIdentName.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,13 @@
:local(.-a0-34a___f) {
color: red;
}

:local(.m_x_\@) {
margin-left: auto !important;
margin-right: auto !important;
}

:local(.B\&W\?) {
margin-left: auto !important;
margin-right: auto !important;
}
alreadyExisted marked this conversation as resolved.
Show resolved Hide resolved
22 changes: 22 additions & 0 deletions test/localIdentName-option.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,26 @@ describe('localIdentName option', () => {
expect(stats.compilation.warnings).toMatchSnapshot('warnings');
expect(stats.compilation.errors).toMatchSnapshot('errors');
});

it('should сorrectly replace escaped symbols in selector', async () => {
const config = {
loader: {
options: {
importLoaders: 2,
localIdentName: '[local]--[hash:base64:4]',
modules: true,
},
},
};
const testId = './modules/localIdentName.css';
const stats = await webpack(testId, config);
const { modules } = stats.toJson();
const module = modules.find((m) => m.id === testId);
const evaluatedModule = evaluated(module.source, modules);

expect(evaluatedModule).toMatchSnapshot('module (evaluated)');
expect(evaluatedModule.locals).toMatchSnapshot('locals');
expect(stats.compilation.warnings).toMatchSnapshot('warnings');
expect(stats.compilation.errors).toMatchSnapshot('errors');
});
});