Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

ESLint 3.0 is out #96

Closed
avindra opened this issue Jul 1, 2016 · 7 comments
Closed

ESLint 3.0 is out #96

avindra opened this issue Jul 1, 2016 · 7 comments

Comments

@avindra
Copy link

avindra commented Jul 1, 2016

This warning is emitted upon installation with [email protected]:

npm WARN [email protected] requires a peer of eslint@>=1.6.0 <3.0.0 but none was installed.

@MoOx
Copy link
Contributor

MoOx commented Jul 1, 2016

Are you aware of any breaking changes that might affect this loader?

@avindra
Copy link
Author

avindra commented Jul 1, 2016

I read the release notes and saw the only breaking changes were to the
default rules, so it shouldn't impact the loader.
On Fri, Jul 1, 2016 at 3:57 PM Maxime Thirouin [email protected]
wrote:

Are you aware of any breaking changes that might affect this loader?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#96 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAHvgN6S0w1VPIiKltpmbIvlzqh-ro4Nks5qRXEagaJpZM4JDa9k
.

@avindra
Copy link
Author

avindra commented Jul 1, 2016

The only change I see which may have some impact:

e0d4b19 Breaking: Error thrown/printed if no config found (fixes #5987)
(#6538) (Kevin Partington)
On Fri, Jul 1, 2016 at 4:01 PM Avindra Goolcharan [email protected]
wrote:

I read the release notes and saw the only breaking changes were to the
default rules, so it shouldn't impact the loader.
On Fri, Jul 1, 2016 at 3:57 PM Maxime Thirouin [email protected]
wrote:

Are you aware of any breaking changes that might affect this loader?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#96 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAHvgN6S0w1VPIiKltpmbIvlzqh-ro4Nks5qRXEagaJpZM4JDa9k
.

@klimashkin
Copy link

I checked, it works fine for me with eslint 3
So you can update peer

@avindra
Copy link
Author

avindra commented Jul 1, 2016

I've also tested our project with Eslint 3.0 and found no issues.

@klimashkin
Copy link

And the sooner the better, without this nobody can create shrinkwrap in theirs project :)
ERR! peer invalid: eslint@>=1.6.0 <3.0.0, required by [email protected]

@MoOx MoOx closed this as completed in 427f143 Jul 2, 2016
@MoOx
Copy link
Contributor

MoOx commented Jul 2, 2016

Support added in 1.4.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants