Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

Returns execflow control to cache enabled webpack on linting error #224

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Returns execflow control to cache enabled webpack on linting error #224

merged 2 commits into from
Jul 19, 2018

Conversation

nicolaslt
Copy link
Contributor

@nicolaslt nicolaslt commented Apr 16, 2018

This is an issue with an ancient version of webpack (1.X). It feels like it also might be one with newer versions.

This PR correctly informs Webpack 1.X that an error has happened. It is only relevant when the cache options is enabled, due to webpack.async().

@jsf-clabot
Copy link

jsf-clabot commented Apr 16, 2018

CLA assistant check
All committers have signed the CLA.

@nicolaslt
Copy link
Contributor Author

I retrofitted some tests. Apologies, those should have been in my initial PR.

@nicolaslt
Copy link
Contributor Author

Any chance this could have a merge&release?

@MoOx
Copy link
Contributor

MoOx commented Jul 16, 2018

Can we find better name for this PR? Would help for release notes. Thanks!
I will merge as soon as I am sure on what is this about (I don't use this module anymore but nobody is maintaining it so, I am trying to help...)

@nicolaslt
Copy link
Contributor Author

I'm struggling to find a good title. The shortest yet most correct title I can come up with would be: "Fix not returning execution flow control to webpack when cache option is enabled and one of the files has a linting error".

But that's a bit long.

To be fair though, we sinced moved away from using eslint-loader so it's not a pressing matter for us anymore.

@DiscoNova
Copy link

struggling to find a good title

I know the struggle; naming things is hard ;)

How about "Returns execflow control to cache enabled webpack on linting error"?

@MoOx MoOx merged commit 97761d7 into webpack-contrib:master Jul 19, 2018
@MoOx
Copy link
Contributor

MoOx commented Jul 19, 2018

Thank you!

@nicolaslt nicolaslt changed the title Fix webpack hanging Returns execflow control to cache enabled webpack on linting error Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants