Make (automatic) linting work with newer node versions #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies related to the (automatic) linting, which cause problems when used with newer node versions. Without this, making a commit using for example node 11 is currently impossible. Specifically, the following issues affect this project with its previous dependency versions: - typicode/please-upgrade-node#9 (transitive dependency through `lint-staged`) - conventional-changelog/commitlint#476
|
|
|
Done in master, sorry for delay |
|
Cool, thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Note: This is not checked because this is not a fix in the code but in the build system, and as far as I can see, there is no test setup for that. If there is something I can do here, please let me know.
Motivation / Use-Case
I have a fix for #30, which I wanted to make a PR for, but I couldn't even make a commit. I'm using node
v11.15.0, andlint-stagedcomplained that I should upgrade, because I need node>= 6. This happens becauseplease-upgrade-node, whichlint-stageddepends on, uses simple string comparisons to compare node versions, and lexicographically, we obviously have11 < 6.After upgrading
lint-stagedto a version that depends on a version ofplease-upgrade-nodeusing actual semver logic, I ran into conventional-changelog/commitlint#476, and so I had to update that as well.Breaking Changes
None that I know of.
Additional Info
🤷♂️